Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cloud_firestore - remove deprecated embedding v1 & upgrade dependencies #7147

Merged

Conversation

juliansteenbakker
Copy link
Contributor

Description

This PR:

  • Removes reference to deprecated embedding v1
  • Upgrades gradle & dependencies
  • Upgrades Android compile SDK version
  • Applies some code improvements

Related Issues

As described in #7127 (comment)
part of #7138

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Oct 6, 2021
@juliansteenbakker juliansteenbakker changed the title chore: cloud_firestore - remove deprecated embedding v1 & upgrade dependencies chore: cloud_firestore - remove deprecated embedding v1 & upgrade dependencies Oct 6, 2021
@Salakar Salakar changed the title chore: cloud_firestore - remove deprecated embedding v1 & upgrade dependencies refactor: cloud_firestore - remove deprecated embedding v1 & upgrade dependencies Oct 7, 2021
Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russellwheatley russellwheatley merged commit 16243c5 into firebase:master Oct 7, 2021
@firebase firebase locked and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants