Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): bump Android compileSdkVersion to 31 #7726

Merged
merged 13 commits into from Jan 7, 2022

Conversation

chloe722
Copy link
Contributor

@chloe722 chloe722 commented Dec 28, 2021

Description

Hi all,

Currently Android code latest stable version is 1.7.0

This PR is to support Android core 1.7.0 due to the opened issue:
[firebase_core][firebase_analytics][firebase_crashlytics] Build APK failed:verifyReleaseResources'. in Android core 1.7.0 and compileVersion 31 #7723

By upgrading compileSDKVersion to 31 solve the issue since the issue:
AAPT: error: resource android:attr/lStar not found.

lStar which is a system attribute that's new as of API level 31

This is why causing the error and failed to compile and build APK

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@chloe722
Copy link
Contributor Author

@Salakar Hello Salakar
This is my first time send out the PR to FlutterFire. Noticing that I had to sign the CLA.
I've just signed the CLA. I would like to request for the Repository manager who I suppose is you by seeing you are the 1st person listed in the Insight Tab.( If im tagging the right person) to click re-run button next to description as documentation in CLA :)

Thank you for your help!
Screen Shot 2021-12-28 at 8 24 24 PM

@russellwheatley
Copy link
Member

Hey @chloe722, good work 😄! Is there any chance you could also update the compileSdkVersion version across all the plugins that are listed here which aren't deprecated? We'd prefer to roll these changes inside one PR if possible. Thanks.

@chloe722
Copy link
Contributor Author

chloe722 commented Jan 5, 2022

Hi @russellwheatley

I went through all the listing packages and update the compileSdkVersion that aren't at latest 31. PR is ready to check again ! Thank you :)

@chloe722 chloe722 changed the title feat(core, crashlytics, analytics): Support latest stable Android core 1.7.0 feat(core, crashlytics, analytics,auth,function,cloud_messaging,storage,in_app_messaging,installations,performance,database,remote_config,app_check): Support latest stable Android core 1.7.0 Jan 5, 2022
@chloe722 chloe722 changed the title feat(core, crashlytics, analytics,auth,function,cloud_messaging,storage,in_app_messaging,installations,performance,database,remote_config,app_check): Support latest stable Android core 1.7.0 feat(core, crashlytics, analytics, auth, function, cloud_messaging, storage, in_app_messaging, installations, performance, database, remote_config, app_check): Support latest stable Android core 1.7.0 Jan 5, 2022
@Salakar Salakar changed the title feat(core, crashlytics, analytics, auth, function, cloud_messaging, storage, in_app_messaging, installations, performance, database, remote_config, app_check): Support latest stable Android core 1.7.0 fix(*): bump Android compileSdkVersion to 31 Jan 7, 2022
@Salakar Salakar merged commit a9562ba into firebase:master Jan 7, 2022
Fixmenow13 added a commit to Fixmenow13/flutterfire that referenced this pull request Jan 11, 2022
max-insight added a commit to Insight-Timer/flutterfire that referenced this pull request Jan 14, 2022
 - **FIX**: bump Android `compileSdkVersion` to 31 (firebase#7726). ([a9562ba](firebase@a9562ba))
 - **DOCS**: Provide fallback for `messageId` field for web as JS SDK does not have. (firebase#7234). ([4571abe](firebase@4571abe))
@firebase firebase locked and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants