No confirmation to discard unsaved segment or feature creation modals #3921
Labels
front-end
Issue related to the React Front End Dashboard
good first issue
Good for newcomers
improvement
Is your feature request related to a problem? Please describe.
When creating or editing segments, you can click the
X
at the top right or click anywhere outside of the modal to close the modal. This will immediately destroy any unsaved changes without requiring confirmation. This is error prone and can be very frustrating. Example (same thing happens when editing):segment-confirmation.mov
We do require confirmation for discarding unsaved features, and also mark the tabs with pending changes (the icon besides the
Value
andSegment Overrides
tab headers) - but only for feature editing and not creation.Describe the solution you'd like.
Require confirmation to close any feature or segment modal with unsaved changes.
Describe alternatives you've considered
One option might be, only for creation modals: do not require confirmation to close them, but restore the previous state if the same modal is opened again. This is probably a lot more effort than it's worth, needs to account for multiple organisations/projects, navigating away from the page or refreshing, could potentially store unwanted sensitive data etc.
Additional context
No response
The text was updated successfully, but these errors were encountered: