Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Explorer plugin search with Everything #2656

Open
1 of 2 tasks
DFreezerR opened this issue Apr 19, 2024 · 5 comments
Open
1 of 2 tasks

BUG: Explorer plugin search with Everything #2656

DFreezerR opened this issue Apr 19, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@DFreezerR
Copy link

DFreezerR commented Apr 19, 2024

Checks

  • I have checked that this issue has not already been reported.

  • I am using the latest version of Flow Launcher.

Problem Description

Same search prompts in Flow launcher search box and Everything returns different results. Examples below.

Case 1 Trying to search - C:\Downloads\ venc Well basically you can use any full path + word to search with space between them like {path} {word}

Results in app:
image

Results in Everything:
image

The results clearly different. BUT it somehow works if we add "" to the path or don use full path
Results in app with "":
image

Results in app without full path:
image

It also works if we use some Everything's functions like "parent:":
image

Case 2

Trying to search - C:\Downloads\ *.jpg

Again - can be any extension.
Result in both apps:

image

To me it looks like plugin tries to use "default" search instead of Everything, and only when "forces" with some syntaxis/keywords it can search with Everything.
Why the exact same query not working in plugin search?

Settings in app

image

image

image

image

image

To Reproduce

  1. Install Flow.Launcher (1.17.2)
  2. Switch everything in Explorer plugin to Everything app
  3. Try searching
  4. Install Everything app when asked
  5. Try to search with both Flow.Launcher and Everything with examples I provided

Screenshots

No response

Flow Launcher Version

1.17.2

Windows Build Number

Windows 11 Pro 22631.3155

@DFreezerR DFreezerR added the bug Something isn't working label Apr 19, 2024
@deefrawley
Copy link
Member

Why are you using a space for the filespec after the folder? C:\downloads\*.jpg will find those files

@DFreezerR
Copy link
Author

DFreezerR commented Apr 20, 2024

Why are you using a space for the filespec after the folder? C:\downloads\*.jpg will find those files

But why it shouldn't work? I expected consistency in searching with Everything and Everything in Explorer plugin. I believe C:\downloads\*.jpg is an example of default Windows masked search, while you can use C:\downloads\ *.jpg in Everything. As stated in Everything docs, space used as AND keyword to search for right part and left one, in my example C:\downloads\ is part of the path and *.jpg is file name, and they are combined with logical AND (space). There is a lot of non consistent behavior between Everything and in app plugin - you also can't use something like C:\downloads\ regex:^read

image

The reason I liked the idea of using Everything with Explorer plugin was because Everything has very convenient search for me. But it's troubling as I can't use the same thing in Explorer plugin even though I selected Everything everywhere in the settings.

And I hope you can agree with me that the same search not working in plugin is not very ideal thing.

@deefrawley
Copy link
Member

Flow handles spaces differently to identify keywords and arguments so as to trigger plugins, therefor any functionality of Everything that works with spaces will not work here. I'm not a core developer though so happy for one of them to jump in and confirm or offer alternatives.

@DFreezerR
Copy link
Author

Flow handles spaces differently to identify keywords and arguments so as to trigger plugins, therefor any functionality of Everything that works with spaces will not work here. I'm not a core developer though so happy for one of them to jump in and confirm or offer alternatives.

Thanks though for your answer
Yes, me too. I can understand that Flow might handle spaces differently. But even if so, in that particular case I think there is no problem to make space work as in Everything (though I'm also not a dev here). On screenshots above I can tell that plugin recognized which one it should trigger, even with space, but again it "feels" like it's trying to use "default" search instead of Everything (but maybe I'm wrong).
Would be exciting to see if one of core devs can clarify this situation, and maybe there is a way to make this work consistently.

@deefrawley
Copy link
Member

@jjw24 @taooceros is this possible? If not, let's close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants