New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORS issue when sending email on enterprise extension #2934
Comments
This issue may be nastier to test than I thought. Because puppeteer does not actually allow us to access out-of-process iframes, such as iframes inside Gmail page. The way we were testing such functionality until now was, to find the iframe, get the URL, then open that in a separate tab. Which does not actually test this particular issue, the frame has to be inside Gmail. The issue is here puppeteer/puppeteer#2548 My best attempt may be to have the mouse click blindly in the space where the send button is supposed to be. Then observe if the window goes away.. which would not work either because I don't have a way to fill out that compose window before clicking. So for the typing, maybe we could convince the content script to relay the keypresses (and only enable this for testing..) but that becomes a real mess. Other possibility would be to just try selenium, and see if this test case can run in selenium instead. |
There could also be some test crafted specifically for this, that doesn't really use the secure compose itself, but some sort of an automated interface to just test the cors issue. Which I find may be a too pointed approach - potentially not addressing other similar issues that may happen. |
did not work |
All of these approaches are near impossible (short of forking chromium), or do not actually test the intended issue. The mechanism to create manifests.json file is dynamic, which caused this issue to be not obvious initially. Therefore we will instead test that the appropriate necessary permissions are present in the resulting manifests. |
The fix was tested today locally by changing the manifest file of the extension to include "https://www.googleapis.com/*" as one of the permissions.
Today the following steps will be taken to fully reconcile this:
The text was updated successfully, but these errors were encountered: