Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests performance by testing iframes directly #4929

Closed
sosnovsky opened this issue Feb 1, 2023 · 1 comment · Fixed by #5088
Closed

Improve tests performance by testing iframes directly #4929

sosnovsky opened this issue Feb 1, 2023 · 1 comment · Fixed by #5088
Assignees
@rrrooommmaaa
Labels
actionable PR Submitted Indicated that PR is already submitted for this issue
Milestone
8.5.0: Sign FES m...

Comments

@sosnovsky
Copy link
Collaborator

sosnovsky commented Feb 1, 2023 •
edited

If they actually fixed this site-per-process issue, that would mean we should be able to test the iframes directly where they are, for example, in Live tests we should be able to test them directly from the Gmail page, instead of copying the URL and opening a separate tab, and testing there. That would speed up the tests. Let's file that for another issue (unless you have already done exactly that).

Originally posted by @tomholub in #4928 (comment)
@sosnovsky sosnovsky added this to the 8.4.4: Maintenance milestone Feb 1, 2023
@sosnovsky sosnovsky mentioned this issue Feb 1, 2023
Merged
5 tasks
@tomholub
Copy link
Collaborator

tomholub commented Feb 1, 2023

image

rrrooommmaaa pushed a commit that referenced this issue Feb 20, 2023
#4929 check pgp block in existing iframe
6ab650c
rrrooommmaaa pushed a commit that referenced this issue Feb 20, 2023
#4929 fix
519eb2e
@rrrooommmaaa rrrooommmaaa mentioned this issue Feb 20, 2023
Merged
5 tasks
sosnovsky pushed a commit that referenced this issue Feb 24, 2023
@rrrooommmaaa
#4342 re-fetch cleartext signed message when HTML version is corrupted (
90825f5 
#4961)

* Infrastructure to test GmailElementReplacer #4810

* #4929 check pgp block in existing iframe

* extracting cleartext signed message from text/plain portion by signature

* #4929 fix

* fixed regex

* nicer test

* eslint fix

---------

Co-authored-by: Roman Shevchenko <roman@flowcrypt.com>
@tomholub tomholub modified the milestones: 8.4.5: Maintenance, 8.4.6 Mar 21, 2023
@tomholub tomholub modified the milestones: 8.4.6, 8.4.7 Apr 12, 2023
@rrrooommmaaa rrrooommmaaa mentioned this issue Apr 16, 2023
Merged
5 tasks
@tomholub tomholub modified the milestones: 8.4.7, 8.4.8 May 3, 2023
@rrrooommmaaa rrrooommmaaa self-assigned this Jun 28, 2023
@rrrooommmaaa rrrooommmaaa added the PR Submitted Indicated that PR is already submitted for this issue label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrrooommmaaa rrrooommmaaa

Labels
actionable PR Submitted Indicated that PR is already submitted for this issue
Projects
None yet
Milestone
8.5.0: Sign FES messages, various bug...
Development

Successfully merging a pull request may close this issue.

Speed up and improve tests FlowCrypt/flowcrypt-browser
3 participants
@sosnovsky @tomholub @rrrooommmaaa