Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --concurrency param for browser pool #4955

Open
sosnovsky opened this issue Feb 13, 2023 · 4 comments
Open

Use --concurrency param for browser pool #4955

sosnovsky opened this issue Feb 13, 2023 · 4 comments

Comments

@sosnovsky
Copy link
Collaborator

sosnovsky commented Feb 13, 2023

Shouldn't browser pool and concurrency always be exactly equal? Or is there a reason to have these two numbers diverge? I'd imagine, we could remove special code to choose that FLAKY-GROUP has 1 in the pool, and instead follow whatever the provided --concurrency ?

Originally posted by @tomholub in #4928 (comment)

@sosnovsky
Copy link
Collaborator Author

It seems we can remove --pool-size parameter and just use --concurrency for setting browser pool size

@tomholub
Copy link
Collaborator

provided it works well, yes :-)

@sosnovsky
Copy link
Collaborator Author

I think it should work well, as currently each test uses separate mock api, so they shouldn't interfere.
We can also try to increase concurrency value for flaky group, to check if they'll fail or still pass.

@tomholub tomholub added this to the 8.4.4: Maintenance milestone Feb 22, 2023
@tomholub tomholub modified the milestones: 8.4.5: Maintenance, 8.4.6 Mar 21, 2023
@tomholub tomholub modified the milestones: 8.4.6, 8.4.7 Apr 12, 2023
@tomholub tomholub modified the milestones: 8.4.7, 8.4.8 May 3, 2023
@sosnovsky
Copy link
Collaborator Author

Looks like we'll need to use separate values for --concurrency and --pool-size, as --concurrency param of ava means how many test files (not tests) will be executed simultaneously
(found by @IvanPizhenko at https://github.com/FlowCrypt/enterprise-server/issues/4807)

@tomholub tomholub modified the milestones: 8.5.0, First priority Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants