Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public key-encrypted message named after "noname" didn't recognized as encrypted message based on its content #5726

Closed
martgil opened this issue May 21, 2024 · 3 comments · Fixed by #5727
Assignees
Milestone

Comments

@martgil
Copy link
Collaborator

martgil commented May 21, 2024

Description

We received a report send to flowcrypt compatibility account about a Public key-encrypted message attachment named after "noname" and another "noname" file where it contains Version: 1. The application used the Canary Mail.

The issue produces a seemingly blank page:

image

The noname file attachment content:

image

Reference: https://mail.google.com/mail/u/flowcrypt.compatibility@gmail.com/#inbox/FMfcgzGxTFXMFnDNbgknpqvXKtSmMgSK

@martgil
Copy link
Collaborator Author

martgil commented May 21, 2024

We should be able to recognize each file based on their content types but upon checking, we somehow defaults the attachment type to application/octet-stream but didn't know the reason why so completely yet.

this.type = attachmentMeta.type || 'application/octet-stream';

image

@sosnovsky
Copy link
Collaborator

application/octet-stream is a default mime type for unknown files, so for cases when we don't have any file type set - application/octet-stream is used

@martgil
Copy link
Collaborator Author

martgil commented May 21, 2024

Thanks, Roma - that is right, I knew it later on right after. I'll have more information to add here when needed.

@martgil martgil added this to the 8.5.6 milestone May 22, 2024
sosnovsky pushed a commit that referenced this issue May 25, 2024
…il (#5727)

* Improve encrypted message detection for multipart email

* Add a test

* Add mime type checks for "application/pgp-encrypted"

---------

Co-authored-by: martgil <martroblesit@gmail.com>
ioanmo226 pushed a commit that referenced this issue May 27, 2024
…il (#5727)

* Improve encrypted message detection for multipart email

* Add a test

* Add mime type checks for "application/pgp-encrypted"

---------

Co-authored-by: martgil <martroblesit@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants