Tests failing following semver 7.5.0 update

[Steve-Mcl]

Current Behavior

We currently use semver on vue pages and since it was updated to v7.5.0 tests fail with the error:

Module not found: Error: Can't resolve 'util' in '/home/runner/work/flowforge/flowforge/node_modules/semver/classes'

see this failed run for more detail.

Our current dependency of semver is ^7.3.8 meaning GH will use V7.x and thus hit this issue

Possible workarounds include: (from best/hardest to worst/easiest)

• drop / replace webpack (something I believe @Pezmc is aiming for?)
• add a fallback in webpack.config.js
• replace semver with a browser ready module
• browserfy semver
• lock semver to pre v7.5.0 - done in Lock semver to minor changes #2078
  • until semver resolves this or makes a browser ready dist.

NOTE:

Anyone installing FF fresh will probably also hit this issue

Expected Behavior

tests to run without this error

Steps To Reproduce

raise a new PR that causes frontend tests to run

Environment

• FlowForge version: 1.6.x-git

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

[Steve-Mcl]

re-opening as the PR #2078 locking semver to version pre 7.5.0 is a temporary fix.

A permanent fix as described in the OP is preferred.

[knolleary]

Given we only use semver in one place in the frontend (introduced by #2042) another option is to just add the couple lines of code needed to do the required version check rather than import a whole module (whether semver or another) to do it.

This issue should not be the driving factor for replacing webpack - that's a bigger piece of work.

[Steve-Mcl]

Alternatively, a possible contender: https://www.npmjs.com/package/compare-versions

This NPM lib has a healthy weekly download, is half the size of semver, is browser ready and has no deps.

[Pezmc]

PR to follow is https://github.com/npm/node-semver/pull/559/files

[joepavitt]

Closed by Update semver to avoid CVE #2718