-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Axios version? #58
Comments
I can't unblock it because of axios/axios#2295. The interceptor wouldn't work properly without the custom request parameters which were deleted in v0.19 of axios. This is a known bug and should be re-added to axios, but as of now, we cannot support axios 0.19 |
Then how come it is working fine for me on axios 0.19? The project may have a dependency on 0.18 but you don't have control over the axios instance version that the library gets. (Or as long as I don't want to skip the interceptor, it will be fine?) |
This has been fixed in axios/axios#2207, so I guess we don't need to bother any more (it has not published yet). Also, I think it will be nice to add axios as an peerDependency instead of dependency. |
@Flyrell Axios v0.19.1 is released and it includes axios/axios#2207. Can we get peerDependency to |
@tmilos Will try to update ASAP. Would you please open a new issue? thanks |
Hi, I tried the new TS supported version but it throws "incompatible types" errors. It's probably, because the axios version is locked to ~0.18.0 but the latest release is 0.19. Maybe unblock this restriction so that npm could use the latest to avoid type conflicts?
edit I'm happy to make a PR if we agree on some solution.
The text was updated successfully, but these errors were encountered: