Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can croppie be updated to support heic files? #782

Open
xxxmicrobexxx opened this issue Dec 19, 2022 · 2 comments
Open

Can croppie be updated to support heic files? #782

xxxmicrobexxx opened this issue Dec 19, 2022 · 2 comments

Comments

@xxxmicrobexxx
Copy link

Croppie is great, but it doesn't support heic images. Any chance of adding that functionality?

@bret-miller
Copy link

From what I understand about Croppie, which I admit is limited my own use and knowledge of JavaScript, it seems like a trivial change to line 1398:

RESULT_FORMATS = ['jpeg', 'webp', 'png', 'heic'];

I personally always pull png and use PHP to convert to the desired destination format. Even PHP doesn't yet support heic, though you can call imagemagick to convert. Since Croppie works internally with "canvas" and not a particular image format, any browser-supported output format should work simply by adding it to the allowed list of result formats.

I could do a pull request for the change but I don't have a good way to test it. And I don't have any permission to merge the pull request back in so I'm not sure it would ever be included. The last included change was in April 2019. So while Croppie still works great, it seems to be a relatively dead project.

@Forage
Copy link

Forage commented Jan 20, 2023

Duplicate of #763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants