Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typings does not work with throat(Promise) syntax #28

Open
unional opened this issue Jul 17, 2017 · 2 comments
Open

Typings does not work with throat(Promise) syntax #28

unional opened this issue Jul 17, 2017 · 2 comments

Comments

@unional
Copy link

unional commented Jul 17, 2017

// Argument of type 'PromiseConstructor' is not assignable to parameter of type 'number'.
const throat = require('throat')(Promise);

cc/ @blakeembrey as typings/core is using this.

@blakeembrey
Copy link

Ah, that must be where this project broke Typings. Thanks for investigating that. @ForbesLindesay I think we just need an additional overload for promise passing.

@unional
Copy link
Author

unional commented Jul 18, 2017

This is one of the issues I encounter when I try to fix the typings/core.
I was trying to update some typings and use @types when I encounter this. When this is fix I can spend some time to complete that on https://github.com/typings/core/tree/to-at-types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants