Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Java 8 Nashorn Engine #22

Closed
winterbe opened this issue Feb 4, 2015 · 2 comments
Closed

Add support for Java 8 Nashorn Engine #22

winterbe opened this issue Feb 4, 2015 · 2 comments

Comments

@winterbe
Copy link

winterbe commented Feb 4, 2015

The template.js fails to evaluate on Java 8 Nashorn. Nashorn doesn't support any module system like AMD out of the box and there's neither global nor window. The global context is available via this.

Please add another fallback to this in template.js.

This refers to: facebook/react#3037
@winterbe
Copy link
Author

winterbe commented Feb 4, 2015

Awesome, thanks! 💃

@ForbesLindesay
Copy link
Owner

You will need to wait for browserify/browser-pack#49 before I expect it will get to react of course :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@winterbe @ForbesLindesay