Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wait the server to be closed when calling agent.close #1107

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

ghusse
Copy link
Member

@ghusse ghusse commented Apr 15, 2024

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

Copy link

codeclimate bot commented Apr 15, 2024

Code Climate has analyzed commit 00a76b5 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 83.3% (98% is the threshold).

This pull request will bring the total coverage in the repository to 97.5% (0.0% change).

View more on Code Climate.

@ghusse ghusse merged commit cc44b7e into main Apr 15, 2024
20 of 22 checks passed
@ghusse ghusse deleted the fix/close-server branch April 15, 2024 07:03
forest-bot added a commit that referenced this pull request Apr 15, 2024
## [1.8.11](https://github.com/ForestAdmin/agent-nodejs/compare/example@1.8.10...example@1.8.11) (2024-04-15)

### Bug Fixes

* **security:** patch tar dependency vulnerabilities ([#1106](#1106)) ([0422c1f](0422c1f))
* wait the server to be closed when calling agent.close ([#1107](#1107)) ([cc44b7e](cc44b7e))
forest-bot added a commit that referenced this pull request Apr 15, 2024
## [1.39.2](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/agent@1.39.1...@forestadmin/agent@1.39.2) (2024-04-15)

### Bug Fixes

* **security:** patch tar dependency vulnerabilities ([#1106](#1106)) ([0422c1f](0422c1f))
* wait the server to be closed when calling agent.close ([#1107](#1107)) ([cc44b7e](cc44b7e))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.9.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.8.11 🎉

The release is available on example@1.8.11

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.39.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Apr 16, 2024
## [1.3.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-mongo@1.3.0...@forestadmin/datasource-mongo@1.3.1) (2024-04-16)

### Bug Fixes

* **mongoose:** error when flattening collections with a dot in their name ([#1109](#1109)) ([6b803ba](6b803ba))
* **security:** patch mysql2 dependency vulnerabilities ([#1108](#1108)) ([c31854b](c31854b))
* **security:** patch tar dependency vulnerabilities ([#1106](#1106)) ([0422c1f](0422c1f))
* wait the server to be closed when calling agent.close ([#1107](#1107)) ([cc44b7e](cc44b7e))
forest-bot added a commit that referenced this pull request Apr 16, 2024
## [1.7.3](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-mongoose@1.7.2...@forestadmin/datasource-mongoose@1.7.3) (2024-04-16)

### Bug Fixes

* **mongoose:** error when flattening collections with a dot in their name ([#1109](#1109)) ([6b803ba](6b803ba))
* **security:** patch mysql2 dependency vulnerabilities ([#1108](#1108)) ([c31854b](c31854b))
* **security:** patch tar dependency vulnerabilities ([#1106](#1106)) ([0422c1f](0422c1f))
* wait the server to be closed when calling agent.close ([#1107](#1107)) ([cc44b7e](cc44b7e))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.3.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.7.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Apr 17, 2024
## [1.3.9](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-replica@1.3.8...@forestadmin/datasource-replica@1.3.9) (2024-04-17)

### Bug Fixes

* **cloud:** error because of missing sqlite3 dependency ([#1112](#1112)) ([2f57d0c](2f57d0c))
* **mongoose:** error when flattening collections with a dot in their name ([#1109](#1109)) ([6b803ba](6b803ba))
* **security:** patch mysql2 dependency vulnerabilities ([#1108](#1108)) ([c31854b](c31854b))
* **security:** patch tar dependency vulnerabilities ([#1106](#1106)) ([0422c1f](0422c1f))
* wait the server to be closed when calling agent.close ([#1107](#1107)) ([cc44b7e](cc44b7e))
forest-bot added a commit that referenced this pull request Apr 17, 2024
## [1.14.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sql@1.14.0...@forestadmin/datasource-sql@1.14.1) (2024-04-17)

### Bug Fixes

* **cloud:** error because of missing sqlite3 dependency ([#1112](#1112)) ([2f57d0c](2f57d0c))
* **mongoose:** error when flattening collections with a dot in their name ([#1109](#1109)) ([6b803ba](6b803ba))
* **security:** patch mysql2 dependency vulnerabilities ([#1108](#1108)) ([c31854b](c31854b))
* **security:** patch tar dependency vulnerabilities ([#1106](#1106)) ([0422c1f](0422c1f))
* wait the server to be closed when calling agent.close ([#1107](#1107)) ([cc44b7e](cc44b7e))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.3.9 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.14.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request May 20, 2024
## [1.27.2](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/forestadmin-client@1.27.1...@forestadmin/forestadmin-client@1.27.2) (2024-05-20)

### Bug Fixes

* **cloud:** error because of missing sqlite3 dependency ([#1112](#1112)) ([2f57d0c](2f57d0c))
* **mongoose:** error when applying auto flattening on deeply nested collections ([#1114](#1114)) ([426a6ae](426a6ae))
* **mongoose:** error when flattening collections with a dot in their name ([#1109](#1109)) ([6b803ba](6b803ba))
* **mongoose:** max call stack size error when using auto flattening with empty property names ([#1113](#1113)) ([ae096d1](ae096d1))
* **security:** patch ejs dependency vulnerabilities ([#1118](#1118)) ([009c89d](009c89d))
* **security:** patch mysql2 dependency vulnerabilities ([#1108](#1108)) ([c31854b](c31854b))
* **security:** patch mysql2 dependency vulnerabilities ([#1115](#1115)) ([aebae2a](aebae2a))
* **security:** patch tar dependency vulnerabilities ([#1106](#1106)) ([0422c1f](0422c1f))
* wait the server to be closed when calling agent.close ([#1107](#1107)) ([cc44b7e](cc44b7e))

### Features

* **agent:** allow parsing multiple sorting fields ([#1117](#1117)) ([e1cd78b](e1cd78b))

### Performance Improvements

* **mongoose:** speed up queries with relationships by filtering before retrieving relations ([#1116](#1116)) ([ff0bfc9](ff0bfc9))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.27.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants