Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agent): allow parsing multiple sorting fields #1117

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

nbouliol
Copy link
Member

CU-86by1y3z6

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@forest-bot
Copy link
Member

Copy link

codeclimate bot commented Apr 27, 2024

Code Climate has analyzed commit 96596e7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (98% is the threshold).

This pull request will bring the total coverage in the repository to 97.5%.

View more on Code Climate.

@nbouliol
Copy link
Member Author

Request:

http://localhost:3311/forest/buns?timezone=Europe/Paris&fields[buns]=id&filters={"field":"flavor","operator":"equal","value":"chicken"}&page[number]=1&page[size]=10&segmentName=chicken&sort=buns_count,-is_good,flavor
&sort=buns_count,-is_good,flavor

Generated query:

SELECT "id"
FROM "buns" AS "buns"
WHERE (
        "buns"."flavor" = 'chicken'
        AND (
            "buns"."id" != 6
            AND "buns"."id" != 395
        )
    )
ORDER BY "buns"."buns_count" ASC,
    "buns"."is_good" DESC,
    "buns"."flavor" ASC
LIMIT 10 OFFSET 0;

@nbouliol nbouliol merged commit e1cd78b into main Apr 29, 2024
22 checks passed
@nbouliol nbouliol deleted the feat/allow-multiple-sorting-field-parsing branch April 29, 2024 10:46
forest-bot added a commit that referenced this pull request Apr 29, 2024
## [1.8.17](https://github.com/ForestAdmin/agent-nodejs/compare/example@1.8.16...example@1.8.17) (2024-04-29)

### Features

* **agent:** allow parsing multiple sorting fields ([#1117](#1117)) ([e1cd78b](e1cd78b))
forest-bot added a commit that referenced this pull request Apr 29, 2024
# [1.40.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/agent@1.39.2...@forestadmin/agent@1.40.0) (2024-04-29)

### Bug Fixes

* **cloud:** error because of missing sqlite3 dependency ([#1112](#1112)) ([2f57d0c](2f57d0c))
* **mongoose:** error when applying auto flattening on deeply nested collections ([#1114](#1114)) ([426a6ae](426a6ae))
* **mongoose:** error when flattening collections with a dot in their name ([#1109](#1109)) ([6b803ba](6b803ba))
* **mongoose:** max call stack size error when using auto flattening with empty property names ([#1113](#1113)) ([ae096d1](ae096d1))
* **security:** patch mysql2 dependency vulnerabilities ([#1108](#1108)) ([c31854b](c31854b))
* **security:** patch mysql2 dependency vulnerabilities ([#1115](#1115)) ([aebae2a](aebae2a))

### Features

* **agent:** allow parsing multiple sorting fields ([#1117](#1117)) ([e1cd78b](e1cd78b))

### Performance Improvements

* **mongoose:** speed up queries with relationships by filtering before retrieving relations ([#1116](#1116)) ([ff0bfc9](ff0bfc9))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.9.9 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.8.17 🎉

The release is available on example@1.8.17

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.40.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request May 20, 2024
## [1.27.2](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/forestadmin-client@1.27.1...@forestadmin/forestadmin-client@1.27.2) (2024-05-20)

### Bug Fixes

* **cloud:** error because of missing sqlite3 dependency ([#1112](#1112)) ([2f57d0c](2f57d0c))
* **mongoose:** error when applying auto flattening on deeply nested collections ([#1114](#1114)) ([426a6ae](426a6ae))
* **mongoose:** error when flattening collections with a dot in their name ([#1109](#1109)) ([6b803ba](6b803ba))
* **mongoose:** max call stack size error when using auto flattening with empty property names ([#1113](#1113)) ([ae096d1](ae096d1))
* **security:** patch ejs dependency vulnerabilities ([#1118](#1118)) ([009c89d](009c89d))
* **security:** patch mysql2 dependency vulnerabilities ([#1108](#1108)) ([c31854b](c31854b))
* **security:** patch mysql2 dependency vulnerabilities ([#1115](#1115)) ([aebae2a](aebae2a))
* **security:** patch tar dependency vulnerabilities ([#1106](#1106)) ([0422c1f](0422c1f))
* wait the server to be closed when calling agent.close ([#1107](#1107)) ([cc44b7e](cc44b7e))

### Features

* **agent:** allow parsing multiple sorting fields ([#1117](#1117)) ([e1cd78b](e1cd78b))

### Performance Improvements

* **mongoose:** speed up queries with relationships by filtering before retrieving relations ([#1116](#1116)) ([ff0bfc9](ff0bfc9))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.27.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.3.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants