(react) - Fix client-side Suspense update edge-case #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8e93fa1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kitten
force-pushed
the
fix/suspense-sync-update
branch
from
4dc9df8
to
a196627
Compare
kitten
force-pushed
the
fix/suspense-sync-update
branch
from
015f6ca
to
8e93fa1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1150
Summary
We encountered another edge-case in client-side React Suspense, which is caused by React handling suspense-on-updates differently than suspense-on-mount. We basically have to be more sensible with state on suspense-on-update because React doesn't clear any state when we suspend during an update.
This can be tested against this reproduction sandbox: https://codesandbox.io/s/ecstatic-ritchie-lzxvl (See CodeSandbox CI output)
Set of changes
inputinuseSourcewhen subscribing