Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using self-hosted icons #134

Open
jbandura opened this issue Jan 15, 2020 · 3 comments
Open

Allow using self-hosted icons #134

jbandura opened this issue Jan 15, 2020 · 3 comments

Comments

@jbandura
Copy link

jbandura commented Jan 15, 2020

Is your feature request related to a problem? Please describe.
Feature request.

We're trying to upgrade to FA 5 in our app. We've bought the PRO icon set, and have the zip ready - however here we've hit a bump. The docs only mention using the private NPM package if you want to use the PRO icons. What happens if you'd prefer to use self-hosted version? Is that possible/on the roadmap?

Describe the solution you'd like
Ability to use self-hosted icons, instead of pulling them from private NPM registry.

@netes
Copy link

netes commented Mar 30, 2020

Bump!

@jrjohnson
Copy link
Collaborator

@jbandura / @netes can you talk a bit about why. Are you not running ember-cli, or not using NPM?

@netes
Copy link

netes commented Mar 30, 2020

@jbandura / @netes can you talk a bit about why. Are you not running ember-cli, or not using NPM?

Sure. The first thing is reliability - today we had a few 500 coming from the https://npm.fontawesome.com during builds so it makes us think what if we have "emergency" build with some hotfix and this occurs? I'm on the side that the less external services we depend on - the better.
Second thing is, that you need every developer to set the token in the ENV variable. It's not a problem with a few devs, but with the bigger teams - it's just inconvenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants