Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing @click is discouraged by linting #166

Open
jrjohnson opened this issue Mar 4, 2021 · 2 comments
Open

Passing @click is discouraged by linting #166

jrjohnson opened this issue Mar 4, 2021 · 2 comments
Assignees

Comments

@jrjohnson
Copy link
Collaborator

In v3 of ember-template-lint passing @click is now flagged in the default rules the suggested change is to modify this API to @onClick.

We'll probably want to add both and deprecate using @click. This should still be handled by the component and not by the consumer because FA adds additional a11y attributes when a click handler is added to an icon.

@jrjohnson jrjohnson self-assigned this Mar 4, 2021
@cah-brian-gantzler
Copy link

cah-brian-gantzler commented Nov 17, 2021

I dont see where this addon supports an @click param. How exactly were you using this?

@cah-brian-gantzler
Copy link

FA adds additional a11y attributes when a click handler is added to an icon.

And where are you seeing this happening?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants