Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null classes showing up on svg in 0.1.5 #289

Closed
MrSauceman opened this issue Sep 30, 2019 · 3 comments
Closed

Null classes showing up on svg in 0.1.5 #289

MrSauceman opened this issue Sep 30, 2019 · 3 comments

Comments

@MrSauceman
Copy link

With the latest release, css classes like ‘fa-null’ and ‘fa-rotate-null’ are showing up on the svg element.

I created a small project that reproduces this behavior: https://codesandbox.io/s/eloquent-framework-ipyx9

Just inspect the icon in dev tools and check the classes on the svg element.

This does not happen in v0.1.4.

@robmadole
Copy link
Member

0.1.6 released that should resolve this. Let us know if it's not working as expected!

@collinpage
Copy link

Not sure if this is related but I get these classes from SSR:
fa-rotate-null
fa-pull-null

It only seems to do this with the fa-sign-in icon (https://fontawesome.com/icons/sign-in?style=regular).

This happens with 0.1.6 and 0.1.7.

if I downgrade to 0.1.5, I don't get the error from font awesome but I get a similar error with the sub-menu icon from ant design (really strange).

@robmadole
Copy link
Member

@collinpage could you perhaps provide a reproducible test case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants