Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Longer build times on FontAwesome v6 #145

Open
saransh-malik opened this issue Sep 20, 2022 · 6 comments
Open

Longer build times on FontAwesome v6 #145

saransh-malik opened this issue Sep 20, 2022 · 6 comments

Comments

@saransh-malik
Copy link

Describe the bug
So if I update my fontawesome libraries to v6, the build times for iOS and Android shoot up by a good amount. I reverted back and was able to solve the issue, so something is definitely causing troubles with v6 only.
There is also a open issue on fontawesome library but since its a react native specific issue, thought of opening it up here. I tried all ways of importing icons and even then the build times didn't change.

Expected behavior
Build times should remain same

@robmadole
Copy link
Member

@saransh-malik we added more icons to v6 but there does seem to be something else going on here.

We haven't solved it yet but we'll add it to the list to look at.

@saransh-malik
Copy link
Author

@robmadole Thanks a lot :)

@alexandrubichis
Copy link

Hello. When you'll set a milestone for this issue?

@femmon
Copy link

femmon commented Nov 1, 2022

We are importing everything and Metro's minification step is taking a lot of time for us. So we use a patch to skip it for Font Awesome FortAwesome/Font-Awesome#19272 (comment)

@saransh-malik
Copy link
Author

@femmon Oh well will try this out.

@saransh-malik
Copy link
Author

@robmadole excluding font awesome from minify actually brings back the original build times. So the issue here is too many new icons slowing the minification or anything else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants