Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back button after sequences navigation sometimes crashes #865

Closed
jimrandomh opened this issue Aug 26, 2018 · 2 comments
Closed

Back button after sequences navigation sometimes crashes #865

jimrandomh opened this issue Aug 26, 2018 · 2 comments
Labels
2. Medium Priority (Hard) 4. Bug

Comments

@jimrandomh
Copy link
Collaborator

Start reading a sequence, eg here. Navigate around a bit using the prev/next links at the top and the back button. Sometimes (not clear what the trigger is), the page will be replaced with

Error: RangeError: Maximum call stack size exceeded
@jimrandomh jimrandomh mentioned this issue Oct 23, 2018
Closed
@jimrandomh
Copy link
Collaborator Author

jimrandomh commented Oct 29, 2018 •
edited

Caused by nfl/react-helmet#373 . There is a PR open against react-helmet (nfl/react-helmet#402) which claims to fix it.

@jimrandomh
Copy link
Collaborator Author

The PR has been sitting open for a month, and the project has not merged anything since February. It seems plausible that the correct fix for this is to get Vulcan to sever its dependency on the library by moving all react-helmet code into Vulcan, and apply the fix there.

jimrandomh added a commit to jimrandomh/Lesswrong2 that referenced this issue Oct 30, 2018
@jimrandomh
Fix crashes in Sequence navigation
1ba3174 
Works around a bug in react-helmet by giving `Helmet` a key that changes
with every navigation, so that `Helmet.componentShouldUpdate` (which is
crashy) doesn't get called. Fixes ForumMagnum#865.
@jimrandomh jimrandomh mentioned this issue Oct 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2. Medium Priority (Hard) 4. Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jimrandomh