Menubar theming issue on Linux

[al2me6]

It seems that the new version of Electron now uses the system theme for the menubar on GTK. However, it does not seem to use the text color, resulting in unreadable text (black on black) if a dark theme is selected.

Kubuntu 18.10, Mailspring 1.50

[bengotow]

Hey! Wow interesting–this seems like a big oversight on the Electron front. Is this picture here accurate? electron/electron#9681 (Where just the selected highlighted item appears black-on-black?) or is it /all/ the menu bar text?

[al2me6]

Hi!

Yes, it is quite similar to what you have linked, but not quite the same. The hover state of the menu doesn't have any effect on the text color, it always stays black. Like I said, the best way to describe it is that the menu bar is inheriting the background color from the GTK theme but keeping the default text color.

I'll see if I can replicate this on Mint (GTK only) and Fedora.

[alecbcs]

Same issue here with Mailspring 1.5.2 on Solus. The menu bar is completely black.

[emilioestebanez]

I have the same issue on Ubuntu 18.10 using the default theme (Yaru)

[luchmhor]

Same for me: black on black using kde with Adapta for qt5 and gtk3. Changing the mailspring theme doesn't affekt the dark menu bar with dark text.

[GulajavaMinistudio]

Same here in VS Code, and Gitkraken, what kind of bugs is this ?

[alexandru-calinoiu]

Visual studio has a work around for it, you can choose not to use the system menubar. Is something like this possible in mailspring?

[raulperdomo]

Same issue here with a dark theme on Fedora 29

[bengotow]

Hey folks—v1.5.4 just shipped earlier today and now uses the latest version of Electron (4.0.0). Could you give the new version a spin and see if it addresses this issue?

[al2me6]

Just tested... unfortunately no change.

Kubuntu 18.10, Plasma 5.14.4

[bengotow]

hmm thanks for checking, that's good to know—we'll probably need to push this upstream to Electron and see what's going on!

[bengotow]

hey folks—it looks like this patch (electron/electron#16223) was included in Electron 4.0.1 which I think may fix this issue? I'll bump to 4.0.1 in the next release and we can verify.

[al2me6]

Thank you, confirmed fixed in 1.5.6!