Skip to content
This repository has been archived by the owner on Apr 21, 2022. It is now read-only.

@pika/plugin-build-types should also support "typings" for custom type definitions #18

Open
ghengeveld opened this issue Mar 3, 2019 · 1 comment

Comments

@ghengeveld
Copy link

ghengeveld commented Mar 3, 2019

I have a custom .d.ts file and a "typings" key in my package.json. Took me a while to figure out why plugin-build-types wasn't picking it up...

From the TypeScript docs:

Note that the "typings" field is synonymous with "types", and could be used as well.

@FredKSchott
Copy link
Owner

Yea, that's a great point that it's difficult to tell from the output what actually has been picked up and why.

I want to be a bit careful using package.json properties, since one thing that @pika/pack tries to do is handle the package.json configuration of entrypoints for you. We could use the top-level "typings" config to let you point to your own custom typings file (but then give you a new entrypoint location in your generated package). Or we could have it be a plugin option defined in your pipeline to keep that separation intact.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@ghengeveld @FredKSchott and others