Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Closing development leaves phantom processes #425

Closed
FredKSchott opened this issue Jun 5, 2020 · 3 comments
Closed

Windows: Closing development leaves phantom processes #425

FredKSchott opened this issue Jun 5, 2020 · 3 comments
Labels
bug Something isn't working contributors welcome! contributors welcome!

Comments

@FredKSchott
Copy link
Owner

FredKSchott commented Jun 5, 2020

Original Discussion: https://www.pika.dev/npm/snowpack/discuss/295
/cc @Ciantic, @FredKSchott

Tracked it down to readline not properly triggering execa cleanup.

@Ciantic if we can't get execa's automatic cleanup triggering, we can try to connect our own exit listener to call .kill() on the execa processes manually.

@FredKSchott FredKSchott added bug Something isn't working contributors welcome! contributors welcome! labels Jun 5, 2020
@Ciantic
Copy link

Ciantic commented Jun 8, 2020

I opened an issue to here sindresorhus/execa#429 with my smaller repro.

@FredKSchott
Copy link
Owner Author

@Ciantic any luck? I'm going to go ahead and close this since we are no longer doing any capturing of SIGKILL commands or the like that could be causing this on our end. If there is an issue here, then it's inside of execa, and hopefully they're able to reproduce and fix.

@Ciantic
Copy link

Ciantic commented Aug 14, 2020

I will try to reproduce this again. But last with tests I was able to reproduce this in Windows 10 Virtual Machine, so it did definitely exist, and it was reproducible most of the time.

I actually switched using WSL (Linux Environment) because of this, so I didn't dig any deeper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working contributors welcome! contributors welcome!
Projects
None yet
Development

No branches or pull requests

2 participants