New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle Grid button should be a toggle button that reflects the visibility status of the grid #13527
Comments
@furgo16 this isn't exactly what you asked for but you can hack the colour changes to be only checked/unchecked, I personally like to be able to see all three states, On (green), Off but available (red) and unavailable (transparent). With it all being Python you don't need to compile to test, see main...Syres916:FreeCAD:Draft_Grid_Observer for changes (ignore the CMakeLists.txt change). My personal stylesheet picks up the checked/unchecked for the menu icon to automatically update:
|
@Syres916 oh, wow, thanks! Except for the colors, that was exactly what I was looking for. A few notes/questions after testing your branch, and using the Classic theme:
Let me know if there is anything I can do to help if you're planning to submit a PR. |
@furgo16 I've updated the branch to be just enabled/disabled and checked/unchecked so any colours only come from the user's stylesheet which deals with 1, 2 and 3. With regard to question 4, the command should not be available when the mdi area is not the editable 3D view, in other words no open project, Techdraw sheet in view etc should disable the Toggle_Grid command. To be honest I nolonger try to get involved in PR's with regard to subjective matters the agro isn't worth it for me. You're welcome to cherry pick any of my code and submit your own solution, I think there will be some |
Thanks! I'll look into it in the next few days. Happy to submit the PR from that code, if that helps getting it merged for everyone. |
Is there an existing issue for this?
Problem description
When using the Draft workbench, the Toggle Grid toolbar button (
Draft_ToggleGrid
) is a generic click button that toggles the visibility of the grid on or off. However, it does not offer any indication of the grid's status.A usability improvement would be for the button to be an actual toggle switch with two stable states: raised (grid off) or depressed (grid on). This would address the issue that when the grid is not in view it's not easy to find it. It usually requires zooming out and repeatedly toggling the button until the grid is shown in view.
This would be similar to the toggle buttons for the snapping functions, shown here next to the Toggle Grid button:
For completeness, the menu entry under Snapping > Toggle Grid should also show a checkmark when the grid is visible.
Full version info
Subproject(s) affected?
Draft
Anything else?
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: