Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create different layouts for different page styles #155

Open
JayyajGH opened this issue Jan 2, 2020 · 4 comments
Open

Create different layouts for different page styles #155

JayyajGH opened this issue Jan 2, 2020 · 4 comments
Labels
Discussion - Low Needs discussion before implementation. Minor. UX/UI/CSS Requires visual flair

Comments

@JayyajGH
Copy link
Contributor

JayyajGH commented Jan 2, 2020

Currently the site has a number of different major page layouts but this is dealt with on a page by page basis. I propose that we should deal with it using different nuxt page layouts.
For example:

Layout1

<template>
  <div>
    <site-header></site-header>
    <nuxt />
    <site-footer></site-footer>
  </div>
</template>

Layout2

<template>
  <div>
    <site-header></site-header>
    <sidebar option1>
    <nuxt />
     <sidebar option1 option2>
    <site-footer></site-footer>
  </div>
</template>

This would also involve refactoring the header and footer styles and logic out into separate components.

@JayyajGH JayyajGH added the Discussion - Low Needs discussion before implementation. Minor. label Jan 2, 2020
@project-bot project-bot bot added this to Triage in FD Nuxt Client Jan 2, 2020
@edwh edwh added the UX/UI/CSS Requires visual flair label Jan 2, 2020
@edwh
Copy link
Member

edwh commented Jan 2, 2020

I agree with using layouts - it's what they're for, isn't it?

Also agree with moving the navbar stuff out of default into components - too much stuff in default (my fault).

@JayyajGH
Copy link
Contributor Author

JayyajGH commented Jan 2, 2020

So:

  1. Refactor navbar into a component
  2. Create multiple layouts

@edwh
Copy link
Member

edwh commented Jan 2, 2020 via email

@edwh edwh moved this from Triage to DevReady - Low in FD Nuxt Client Jan 2, 2020
@JayyajGH
Copy link
Contributor Author

Currently working on refactoring the default.vue page to try and take the navigation bar stuff into a separate component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion - Low Needs discussion before implementation. Minor. UX/UI/CSS Requires visual flair
Projects
FD Nuxt Client
  
DevReady - Low
Development

No branches or pull requests

2 participants