Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider api deduplication #57

Open
vasilich6107 opened this issue Dec 31, 2021 · 1 comment
Open

Consider api deduplication #57

vasilich6107 opened this issue Dec 31, 2021 · 1 comment

Comments

@vasilich6107
Copy link
Contributor

vasilich6107 commented Dec 31, 2021

Currently package has
selectedButton
selectedButtons

also has
_selectedIndexes
_selectedIndex

Consider simplifying the api to be more generic.
In case of isRadio the _selectedIndexes could be limited to only one item - this will simplifies the api and internal logic

@Frezyx
Copy link
Owner

Frezyx commented Jan 5, 2022

Now this is solved only by factory constructors, which simplify creation of different types buttons.
GroupButton.radio()
GroupButton.checkbox()

In future, I want to do this at controller level, to simplify package logic and make him more lightweight. But now i don't understand how i can make it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants