Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

talker_flutter: TalkerScreen doesn't display stack traces #213

Open
wcoder opened this issue Mar 30, 2024 · 1 comment
Open

talker_flutter: TalkerScreen doesn't display stack traces #213

wcoder opened this issue Mar 30, 2024 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@wcoder
Copy link
Contributor

wcoder commented Mar 30, 2024

Describe the bug
The stack trace is not displayed when TalkerDataCard is expanded.

To Reproduce
Steps to reproduce the behavior:

  1. _talker.error(any exception)
  2. open TalkerScreen

Expected behavior
When the TalkerDataCard is expanded, stack trace should be displayed.

Screenshots
If applicable, add screenshots to help explain your problem.

Env:

  • OS: Android, iOS
  • talker_flutter: 4.1.3

Investigation

The problem is here:

if (widget.data is! TalkerError && widget.data is! TalkerException) {
return null;
}
return 'StackTrace:\n${widget.data.stackTrace}';

The usual widget.data contains a TalkerLog object and is caught by this condition above and returns null.

Workaround

talker.error('$message\nex:$ex\nst:$stacktrace', ex, stacktrace);
@Frezyx Frezyx added bug Something isn't working help wanted Extra attention is needed work_in_progress Сurrently under work labels Apr 5, 2024
@Frezyx
Copy link
Owner

Frezyx commented Apr 5, 2024

Hello @wcoder !
This is really a bug. We need to fix this issue ⚙️

@Frezyx Frezyx removed the work_in_progress Сurrently under work label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants