Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonApiExceptionRenderer should have a method for filtering on Accepts header #188

Open
geoidesic opened this issue Apr 21, 2024 · 0 comments

Comments

@geoidesic
Copy link
Collaborator

        if (!$this->controller->getRequest()->accepts('application/vnd.api+json')) {
            return parent::_outputMessage($template);
        }

This assumes that the usage of this renderer can only apply to jsonapi requests. However, this makes it somewhat inflexible.
It might be better to add a method like shouldBeBypassed, which can then be overridden to allow finer control of this logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant