FinalStaticAccessFixer - deprecate #4673
Merged
+17
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienfalque
force-pushed
the
deprecate-final-static-access
branch
from
d10cc3c to
ebf1c94
Compare
bluedasher13
added a commit
to bluedasher13/PHP-CS-Fixer
that referenced
this pull request
Dec 28, 2019
Should be deprecated in v2.16 & v3.0 & master? PHP-CS-Fixer#4673 julienfalque commented on 28 Nov In v2.16, we added rules ``final_static_access`` and ``self_static_accessor`` but they almost do the same thing so we can actually drop one. I chose to deprecate ``final_static_access`` in favor of ``self_static_accessor`` because the former does not support anonymous classes while the latter does.
julienfalque
force-pushed
the
deprecate-final-static-access
branch
from
ebf1c94 to
656a89c
Compare
SpacePossum
changed the title
|
Thank you @julienfalque. |
SpacePossum
added a commit
that referenced
this pull request
Jan 18, 2020
This PR was merged into the 2.17-dev branch. Discussion ---------- FinalStaticAccessFixer - deprecate In v2.16, we added rules `final_static_access` and `self_static_accessor` but they almost do the same thing so we can actually drop one. I chose to deprecate `final_static_access` in favor of `self_static_accessor` because the former does not support anonymous classes while the latter does. /cc @ntzm @SpacePossum as authors of the rules. Commits ------- 656a89c Deprecate final_static_access rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v2.16, we added rules
final_static_accessandself_static_accessorbut they almost do the same thing so we can actually drop one. I chose to deprecatefinal_static_accessin favor ofself_static_accessorbecause the former does not support anonymous classes while the latter does./cc @ntzm @SpacePossum as authors of the rules.