Skip to content

Assert all project source files are monolithic. #4961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2020
Merged

Assert all project source files are monolithic. #4961

merged 1 commit into from
Jun 14, 2020
+62 −4

Conversation

SpacePossum
Copy link
Contributor

No description provided.

@SpacePossum SpacePossum added this to the 2.15.8 milestone May 20, 2020
@julienfalque
Copy link
Member

What is the value of this test (real question)?

@SpacePossum
Copy link
Contributor Author

I was close to merge 4953, but than spotted this:
https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/4953/files#diff-24535a6889791dd70f4fe486f14c760fR1280

I would like it as autoreview so I don't miss it again.

@julienfalque
Copy link
Member

Not sure that would be spotted: this file is a monolithic PHP file (no inline HTML or multiple open tag).

@SpacePossum
Copy link
Contributor Author

check, I'll update to make sure there is only one named class declaration in the file!

kubawerlos
kubawerlos requested changes May 20, 2020
View reviewed changes
@SpacePossum SpacePossum marked this pull request as draft May 23, 2020 12:08
@SpacePossum SpacePossum marked this pull request as ready for review May 23, 2020 12:09
kubawerlos
kubawerlos approved these changes May 23, 2020
View reviewed changes
@julienfalque
Copy link
Member

Wondering: this looks like static analysis concerns. Isn't there some PHPStan extension that implements similar checks out there? It not, wouldn't it be better to implement one?

@SpacePossum
Copy link
Contributor Author

Maybe, there more of there in the same unit test. I think it would be great a stan plugin but till it exists I think it would be nice ti have here in this form.
When I got time I'll look into making a stan plugin :)

@SpacePossum SpacePossum added the RTM Ready To Merge label Jun 10, 2020
@SpacePossum SpacePossum merged commit 31baa00 into PHP-CS-Fixer:2.15 Jun 14, 2020
@SpacePossum SpacePossum removed the RTM Ready To Merge label Jun 14, 2020
@SpacePossum SpacePossum deleted the 2_15_IsMonolithic_test branch June 14, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubawerlos kubawerlos

Assignees
No one assigned
Labels
kind/enhancement topic/tests
Projects
None yet
Milestone
2.15.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SpacePossum @julienfalque @kubawerlos