Skip to content

PhpdocAnnotationWithoutDotFixer - handle unicode characters using mb_* #4987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2020
Merged

PhpdocAnnotationWithoutDotFixer - handle unicode characters using mb_* #4987

merged 1 commit into from
Jun 14, 2020
+19 −1

Conversation

SpacePossum
Copy link
Contributor

replaces #4977

@SpacePossum SpacePossum added this to the 2.15.8 milestone Jun 2, 2020
@SpacePossum SpacePossum changed the base branch from 2.16 to 2.15 June 2, 2020 05:17
@kubawerlos
Copy link
Contributor

Is this the only case when multibyte can cause trouble with lower/upper casing? Maybe some wrapper similar to Preg class would be useful.

@SpacePossum
Copy link
Contributor Author

it is the only case I could find on 2.15, maybe when we have more candidates in the future we can extract etc.

@SpacePossum SpacePossum added the RTM Ready To Merge label Jun 8, 2020
@SpacePossum SpacePossum removed the RTM Ready To Merge label Jun 14, 2020
@SpacePossum SpacePossum merged commit 2920da6 into PHP-CS-Fixer:2.15 Jun 14, 2020
@SpacePossum SpacePossum deleted the 2_15_PhpdocAnnotationWithoutDotFixer_multibyte_chars branch June 14, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienfalque julienfalque

@kubawerlos kubawerlos

Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
2.15.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SpacePossum @kubawerlos @julienfalque