Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhpdocScalarFixer - fix for comment with Windows line endings #5018

Merged
merged 1 commit into from
Jun 27, 2020
Merged

PhpdocScalarFixer - fix for comment with Windows line endings #5018

merged 1 commit into from
Jun 27, 2020

Conversation

kubawerlos
Copy link
Contributor

No description provided.

@SpacePossum SpacePossum added the RTM Ready To Merge label Jun 22, 2020
@keradus keradus added this to the 2.16.4 milestone Jun 27, 2020
@keradus keradus removed the RTM Ready To Merge label Jun 27, 2020
@keradus
Copy link
Member

keradus commented Jun 27, 2020

Thank you @kubawerlos.

@keradus keradus merged commit 691cf0a into PHP-CS-Fixer:2.16 Jun 27, 2020
@kubawerlos kubawerlos deleted the fix_PhpdocScalarFixer branch June 28, 2020 18:09
@SpacePossum
Copy link
Contributor

@kubawerlos can you check the current 2.15 and 2.16 Annotation class and check if the merge conflict was resolved correctly, secondly the fix in the PR should it also go to 2.15?

@kubawerlos
Copy link
Contributor Author

@SpacePossum that's weird, now when I remove \v on 2.16 the tests are still passing 🤔

@SpacePossum
Copy link
Contributor

maybe my fix on 2.15 has the same effect your fix here on 2.16 has? : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants