Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhpUnitDedicateAssertInternalTypeFixer - deprecate "target" option #5025

Merged
merged 1 commit into from
Aug 6, 2020
Merged

PhpUnitDedicateAssertInternalTypeFixer - deprecate "target" option #5025

merged 1 commit into from
Aug 6, 2020
+8 −2

Conversation

kubawerlos
Copy link
Contributor

The option was not used and is not needed - all the assertions were added in PHPUnit 7.5: https://github.com/sebastianbergmann/phpunit/blob/7.5.20/ChangeLog-7.5.md

Pinging @Slamdunk as the author of fixer.

@Slamdunk
Copy link
Contributor

Mmm, I've redacted the fixer that way because all the fixers of the same kind as redacted so, I guess to provide forward compatibility. Not that I have a preference on the topic, just to share why it is so.

@kubawerlos
Copy link
Contributor Author

@Slamdunk not all of them have it, this option is to let the fixer fix differently for different target and this one has all the assertions it's introducing added in one PHPUnit version.

@SpacePossum
Copy link
Contributor

RTM, but sadly a conflict now, can you resolve @kubawerlos ?

@SpacePossum SpacePossum added the RTM Ready To Merge label Jul 10, 2020
@SpacePossum SpacePossum added this to the 2.17.0 milestone Jul 10, 2020
@kubawerlos
Copy link
Contributor Author

@SpacePossum done

@SpacePossum SpacePossum removed the RTM Ready To Merge label Aug 6, 2020
@SpacePossum
Copy link
Contributor

Thank you @kubawerlos.

@SpacePossum SpacePossum merged commit 395d072 into PHP-CS-Fixer:master Aug 6, 2020
@kubawerlos kubawerlos deleted the PhpUnitDedicateAssertInternalTypeFixer_deprecate_target branch August 6, 2020 20:17
@keradus keradus mentioned this pull request Dec 16, 2020
Merged
keradus added a commit that referenced this pull request Dec 16, 2020
@keradus
minor #5366 PhpUnitDedicateAssertInternalTypeFixer - recover target o…
8b2bc94 
…ption (keradus)

This PR was squashed before being merged into the 2.17 branch.

Discussion
----------

PhpUnitDedicateAssertInternalTypeFixer - recover target option

reverts #5025

Commits
-------

cb29f72 PhpUnitDedicateAssertInternalTypeFixer - recover target option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpacePossum SpacePossum

Assignees
No one assigned
Labels
kind/cleanup
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kubawerlos @Slamdunk @SpacePossum