SwitchContinueToBreakFixer - do not support alternative syntax #5094
+51
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't the fixer actually support alternative syntax in case the |
|
Ideally it would support the alternative syntax, however the time I can spend on this PR is very limited. Maybe someone who actually uses the alternative syntax can send a PR later to add the support for it :) |
GrahamCampbell
suggested changes
Aug 7, 2020
tests/Fixer/ControlStructure/SwitchContinueToBreakFixerTest.php
Outdated
Show resolved
Hide resolved
GrahamCampbell
approved these changes
Aug 7, 2020
|
Thank you @SpacePossum. |
SpacePossum
deleted the
master_SwitchContinueToBreakFixer_do_not_support_alternative_syntax
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5076