Improve InstallViaComposerTest #5267
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanmai
force-pushed
the
InstallViaComposerTest
branch
from
c94b3f5 to
7657d9c
Compare
kubawerlos
approved these changes
Nov 14, 2020
|
Thank you @sanmai. |
keradus
reviewed
Nov 16, 2020
| ]; | ||
| $stepsToPrepareArtifact = [ | ||
| // Configure git user for new repo to not use global git user. | ||
| // We need this, as global git user may not be set! | ||
| 'git config user.name test && git config user.email test', | ||
| // Adjust cloned project to expose version in `composer.json`. | ||
| // Without that, it would not be possible to use it as Composer Artifact. | ||
| "composer config version {$fakeVersion} && git add . && git commit -m 'provide version'", | ||
| "composer config version {$fakeVersion} && git add . && git commit --no-gpg-sign -m 'provide version'", |
There was a problem hiding this comment.
isn't no-gpg-sign default , @sanmai ?
There was a problem hiding this comment.
Yes and no. You can configure Git to sign all commits everywhere, by default. And then this test will fail.
E.g. with:
git config --global commit.gpgsign true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Extracted from #5262