Skip to content

PHP8 - add NoUnreachableDefaultArgumentValueFixer to risky set #5276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2020
Merged

PHP8 - add NoUnreachableDefaultArgumentValueFixer to risky set #5276

merged 1 commit into from
Nov 20, 2020

Conversation

SpacePossum
Copy link
Contributor

@SpacePossum SpacePossum commented Nov 18, 2020

The following no longer parses on PHP8

<?php

function foo($a = 1, $b){
    
}

https://3v4l.org/RQha3

<?php
class Point {
    public function Point(
        public float $x = 70.0) {}
}

$a = new Point();
echo $a->x;

https://3v4l.org/OG8r1

@SpacePossum SpacePossum added kind/enhancement topic/PHP8.0 Related to features available in PHP 8.0+ RTM Ready To Merge labels Nov 18, 2020
@SpacePossum SpacePossum added this to the 2.15.10 milestone Nov 18, 2020
@keradus keradus removed the RTM Ready To Merge label Nov 20, 2020
@keradus
Copy link
Member

keradus commented Nov 20, 2020

Thank you @SpacePossum.

@keradus keradus merged commit c02b834 into PHP-CS-Fixer:2.15 Nov 20, 2020
@SpacePossum SpacePossum deleted the 2_15_no_unreachable_default_argument_value_PHP8 branch November 20, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement topic/PHP8.0 Related to features available in PHP 8.0+
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants