Groom GitHub CI and move some checks from TravisCI to GitHub CI #5305
+61
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
commented
Nov 29, 2020
| @@ -54,6 +57,7 @@ jobs: | |||
| uses: shivammathur/setup-php@v2 | |||
| with: | |||
| php-version: ${{ matrix.php-version }} | |||
| coverage: none | |||
There was a problem hiding this comment.
(look at timing)
Before:
After
keradus
changed the title
sanmai
reviewed
Nov 29, 2020
| - name: Configure Symfony Flex | ||
| run: | | ||
| composer config extra.symfony.require ${{ matrix.execute-flex-with-symfony-version }} | ||
| if: "matrix.execute-flex-with-symfony-version" |
There was a problem hiding this comment.
What do you think if if: would go before run:?
sanmai
approved these changes
Nov 29, 2020
julienfalque
approved these changes
Nov 29, 2020
| @@ -78,13 +100,18 @@ jobs: | |||
| retry_wait_seconds: 30 | |||
| command: | | |||
| composer update --optimize-autoloader --no-interaction --no-progress ${{ matrix.composer-flags }} | |||
| composer info -D | sort | |||
There was a problem hiding this comment.
This is redundant with output of composer update.
There was a problem hiding this comment.
I find -D and sort useful
actually even more useful than output of update. maybe let's use update -q ?
There was a problem hiding this comment.
That would leave us with less information than actually provided.
There was a problem hiding this comment.
so... maybe let's keep both?
There was a problem hiding this comment.
let's merge as-is and we can always adjust later ;)
keradus
force-pushed
the
ci_update2
branch
3 times, most recently
from
5ca4728 to
4829a36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.