Skip to content

DX: collect coverage with Github Actions #5329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2020
Merged

DX: collect coverage with Github Actions #5329

merged 1 commit into from
Dec 23, 2020
+22 −30

Conversation

kubawerlos
Copy link
Contributor

No description provided.

keradus
keradus reviewed Dec 7, 2020
View reviewed changes
keradus
keradus reviewed Dec 7, 2020
View reviewed changes
@keradus
Copy link
Member

keradus commented Dec 7, 2020

pls convert to draft until ready + remove travis CI code coverage job

keradus
keradus reviewed Dec 7, 2020
View reviewed changes
@keradus keradus marked this pull request as draft December 7, 2020 23:24
@kubawerlos
Copy link
Contributor Author

It's working: https://coveralls.io/jobs/71898867

After mergin #5314 small update and we have collecting coverage from GA.

@kubawerlos kubawerlos marked this pull request as ready for review December 16, 2020 06:59
@kubawerlos kubawerlos marked this pull request as draft December 16, 2020 08:00
@keradus
Copy link
Member

keradus commented Dec 16, 2020

diff is huge. can you drop build/logs/clover.xml ?

@kubawerlos kubawerlos closed this Dec 16, 2020
@kubawerlos kubawerlos reopened this Dec 16, 2020
@kubawerlos kubawerlos closed this Dec 16, 2020
@kubawerlos kubawerlos reopened this Dec 16, 2020
@kubawerlos kubawerlos marked this pull request as ready for review December 16, 2020 22:20
@keradus
Copy link
Member

keradus commented Dec 17, 2020

can we have the coverage reported on PR ?

@kubawerlos
Copy link
Contributor Author

@keradus I think so, go to https://coveralls.io/github/FriendsOfPHP/PHP-CS-Fixer/settings > PULL REQUESTS ALERTS and enable LEAVE COMMENTS?.

@keradus keradus changed the base branch from 2.16 to 2.17 December 17, 2020 13:38
@kubawerlos
Copy link
Contributor Author

@keradus can we try this ☝🏼 and merge this PR?

@keradus
Copy link
Member

keradus commented Dec 23, 2020

I decided to merge the change as-is, to unblock coverage for the project.
I agree that there could be some improvements done (eg collect coverage everywhere, not only on 7.4), but I don't see them blocking the PR - please, if you are able to, help and raise a PR to improve coverage integration / github actions further

@keradus keradus added this to the 2.17.3 milestone Dec 23, 2020
@keradus
Copy link
Member

keradus commented Dec 23, 2020

Thank you @kubawerlos.

@keradus keradus merged commit 1250a10 into PHP-CS-Fixer:2.17 Dec 23, 2020
@kubawerlos kubawerlos deleted the collect-coverage-with-github-actions branch August 28, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanmai sanmai

@keradus keradus

Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
2.17.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kubawerlos @keradus @sanmai