Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: Do not display runtime twice on 3.0 line #5364

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

keradus
Copy link
Member

@keradus keradus commented Dec 16, 2020

No description provided.

@keradus keradus added this to the 3.0.0 milestone Dec 16, 2020
@keradus keradus requested a review from SpacePossum December 16, 2020 01:46
@SpacePossum
Copy link
Contributor

Nice catch! 👍
Must have messed up the conflict merging.
Please see the failing utest and when green RTM

@keradus
Copy link
Member Author

keradus commented Dec 16, 2020

CI broken not related. all except 2.16 is broken due to PHPUnit 9 merge

@keradus keradus force-pushed the 3.0_runtime branch 2 times, most recently from 6da3a65 to 4f34024 Compare December 16, 2020 21:08
@SpacePossum SpacePossum added kind/cleanup RTM Ready To Merge labels Dec 16, 2020
@keradus
Copy link
Member Author

keradus commented Dec 17, 2020

looks like 3.0 is broken due to this change on 2.x line... let me see...

@keradus keradus removed the RTM Ready To Merge label Dec 18, 2020
@keradus keradus merged commit 314fed6 into PHP-CS-Fixer:3.0 Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants