Skip to content

PhpUnitDedicateAssertInternalTypeFixer - recover target option #5366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2020
Merged

PhpUnitDedicateAssertInternalTypeFixer - recover target option #5366

merged 1 commit into from
Dec 16, 2020
+13 −14

Conversation

keradus
Copy link
Member

@keradus keradus commented Dec 16, 2020 •
edited
Loading

reverts #5025

@keradus keradus added this to the 2.17.2 milestone Dec 16, 2020
This was referenced Dec 16, 2020
Closed
Merged
@keradus
Copy link
Member Author

keradus commented Dec 16, 2020

Reason 1 https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5351/files?diff=split&w=1#r544162908

it is a way that the default config is VERSION_NEWEST, so we can add support for future PHPUnit versions to the rule WITHOUT a need to change default config, which would be a BC breaker

Reason 2 #5025 (comment)

I guess to provide forward compatibility

@keradus keradus force-pushed the 2.17_recover_option branch 2 times, most recently from 349c6a8 to 793cde1 Compare December 16, 2020 15:46
@keradus keradus force-pushed the 2.17_recover_option branch from 793cde1 to cb29f72 Compare December 16, 2020 17:37
@keradus keradus merged commit 8b2bc94 into PHP-CS-Fixer:2.17 Dec 16, 2020
@keradus keradus deleted the 2.17_recover_option branch December 16, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.17.2
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@keradus