Skip to content

PhpUnitMethodCasingFixer - Do not modify class name #5379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2021
Merged

PhpUnitMethodCasingFixer - Do not modify class name #5379

merged 1 commit into from
Jan 18, 2021
+48 −6

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Dec 19, 2020 •
edited
Loading

This PR

  • asserts that the PhpUnitMethodCasingFixer does not modify class names when using @depends annotations with FooTest::testFoo() style
  • adjusts the PhpUnitMethodCasingFixer to fix only the function name part

Sorry, something went wrong.

@localheinz localheinz marked this pull request as ready for review December 19, 2020 07:59
@localheinz localheinz mentioned this pull request Dec 19, 2020
Closed
2 tasks
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 91.365% when pulling aeff879 on localheinz:fix/class into 98dd819 on FriendsOfPHP:2.17.

@keradus keradus added this to the 2.17.4 milestone Jan 18, 2021
@keradus keradus changed the title [PhpUnitMethodCasingFixer] Do not modify class name PhpUnitMethodCasingFixer - Do not modify class name Jan 18, 2021
@localheinz @keradus
PhpUnitMethodCasingFixer - Do not modify class name

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
6fd0101
@keradus
Copy link
Member

keradus commented Jan 18, 2021

Thank you @localheinz.

@keradus keradus merged commit 7c550c6 into PHP-CS-Fixer:2.17 Jan 18, 2021
@localheinz localheinz deleted the fix/class branch January 18, 2021 07:35
@localheinz
Copy link
Member Author

Thank you, @keradus and @kubawerlos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubawerlos kubawerlos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.17.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@localheinz @coveralls @keradus @kubawerlos