DX: make doc examples prettier #5585
Merged
+242
−467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
reviewed
Apr 4, 2021
| @@ -51,6 +51,7 @@ final class DocumentationGenerator | |||
| public function __construct() | |||
| { | |||
| $this->differ = new Differ(new UnifiedDiffOutputBuilder([ | |||
| 'contextLines' => 1024, // number large enough to have all lines in diff | |||
keradus
approved these changes
Apr 4, 2021
julienfalque
approved these changes
Apr 4, 2021
|
Thank you @kubawerlos. |
Merged
keradus
added a commit
that referenced
this pull request
Apr 6, 2021
keradus
added a commit
that referenced
this pull request
Apr 7, 2021
…er (keradus) This PR was squashed before being merged into the 2.18 branch. Discussion ---------- DX: DocumentationGenerator - no need to re-configure Differ follows #5585 , @kubawerlos , we have actually a FullDiffer class ready for exact case how use configured the differ Commits ------- bb4b790 DX: DocumentationGenerator - no need to re-configure Differ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@@ -1,2 +1,2 @@from diffs.All interesting changes are in
src/Documentation/DocumentationGenerator.phpfile.Ping @julienfalque for review.