Skip to content

GroupImportFixer - fix removal of import type when mixing multiple types #5618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

Leprechaunz
Copy link
Contributor

Fixes #5346

@coveralls
Copy link

coveralls commented Apr 11, 2021

Coverage Status

Coverage increased (+0.003%) to 91.853% when pulling d74483b on Leprechaunz:group-import-mixing-types into 524b57d on FriendsOfPHP:2.18.

@kubawerlos kubawerlos added this to the 2.18.6 milestone Apr 11, 2021
@keradus keradus changed the title group_import removes import type when mixing multiple types GroupImportFixer - fix removal of import type when mixing multiple types Apr 11, 2021
@keradus
Copy link
Member

keradus commented Apr 11, 2021

Hey @Leprechaunz, can you resolve conflict by rebasing the PR, please?

@Leprechaunz Leprechaunz force-pushed the group-import-mixing-types branch from 4cdb5db to 9a31684 Compare April 12, 2021 10:57
@Leprechaunz Leprechaunz force-pushed the group-import-mixing-types branch from 9a31684 to d74483b Compare April 12, 2021 11:03
@Leprechaunz
Copy link
Contributor Author

@keradus resolved conflicts ✅

@keradus
Copy link
Member

keradus commented Apr 14, 2021

Thank you @Leprechaunz.

@keradus keradus merged commit 7a21d69 into PHP-CS-Fixer:2.18 Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

group_import removes import type when mixing multiple types
4 participants