Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis Tag Aware Check wrong #245

Open
artdevil-de opened this issue Feb 6, 2024 · 2 comments
Open

Redis Tag Aware Check wrong #245

artdevil-de opened this issue Feb 6, 2024 · 2 comments
Labels
kind/question Further information is requested

Comments

@artdevil-de
Copy link
Contributor

PHP Version

8.2.15

Shopware Version

6.5.8.2

Plugin Version

1.2.9

Actual behaviour

Redis Tag Aware Warning is displayed

image

Expected behaviour

I would expect no warning, as we do not have the Object Cache on Redis Tag Aware

Our Cache Config uses Redis Tag Aware, but we specifically set the object cache to regular redis.
See config below

framework:
cache:
prefix_seed: "%kernel.cache.hash%"
app: cache.adapter.redis_tag_aware
system: cache.adapter.redis_tag_aware
default_redis_provider: 'redis://%env(REDIS_CACHE_HOST)%:%env(REDIS_CACHE_PORT)%'
pools:
cache.object:
default_lifetime: 3600
adapter: cache.adapter.redis
tags: cache.tags

Steps to Reproduce?

Use the Redis Cache setting from above, and the Redis Tag Aware warning will be displayed

@artdevil-de artdevil-de added the kind/bug Something isn't working label Feb 6, 2024
@tinect
Copy link
Member

tinect commented Feb 6, 2024

@tinect tinect added kind/question Further information is requested and removed kind/bug Something isn't working labels Feb 6, 2024
@artdevil-de
Copy link
Contributor Author

I woud say that the error message is misleading.
The posted cache config works for us, the only cache that throws errors is the "cache.object" in conjunction with Tag Aware Redis.
All other cache in 6.5.8.2 are working fine with Tag Aware Redis.

So I would suggest to only check for the "cache.object" if it is using Tag Aware Redis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants