Added support for the new MaxHeaderValueLengthFormatter #483
Conversation
Toflar
force-pushed
the
support-max-header-length-formatter
branch
from
3affecb
to
fd0f86c
Compare
Toflar
force-pushed
the
support-max-header-length-formatter
branch
from
fd0f86c
to
881b617
Compare
|
cool, thanks! i merged and tagged the bugfix. it seems like the method is not used in the tests here, as they did not fail. but oh yay, code rot. the failures are about lowest version build. i guess they also happen in master now. |
composer.json
Outdated
| @@ -22,7 +22,7 @@ | |||
| ], | |||
| "require": { | |||
| "php": "^7.1", | |||
| "friendsofsymfony/http-cache": "^2.3", | |||
| "friendsofsymfony/http-cache": "^2.5", | |||
There was a problem hiding this comment.
ah, actually this is causing various problems with the lowest version build.
lets bump the branch alias to 2.5 and increase version numbers as needed.
There was a problem hiding this comment.
I might have misunderstood here but I bumped it and it still fails :)
There was a problem hiding this comment.
that was the start, now we have to get rid of old versions of things that we no longer can support. FOSHttpCache stopped supporting symfony 2.x in 2.5. we have to adjust here as well, and can remove the lts 2 build from the matrix.
There was a problem hiding this comment.
Ah true, wouldn't it be better to update master then and I rebase? Otherwise this PR includes a lot of actually unrelated stuff :)
There was a problem hiding this comment.
good point. yes lets do that in a separate pull request. can you do the upgrade?
Toflar
force-pushed
the
support-max-header-length-formatter
branch
from
c10ec5d
to
881b617
Compare
|
can you please rebase on master to see if this is now good? |
Toflar
force-pushed
the
support-max-header-length-formatter
branch
from
881b617
to
2ffeb9e
Compare
|
Here we go 馃帀 |
Let's start Hacktoberfest 2018 a bit earlier 馃槑
Here's the support for FriendsOfSymfony/FOSHttpCache#424. Although I found a very stupid issue in the library itself so that needs to be merged first (FriendsOfSymfony/FOSHttpCache#426).