Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit flow enabled by default for every client #637

Open
marekm4 opened this issue Feb 9, 2020 · 0 comments
Open

Implicit flow enabled by default for every client #637

marekm4 opened this issue Feb 9, 2020 · 0 comments

Comments

@marekm4
Copy link

marekm4 commented Feb 9, 2020

Hi guys, I have a question about implicit flow. I'm a little confused because I can see that other people tried to use this flow on /token endpoint and failed. And it was said that your library doesn't support public clients. But actually implicit flow doesn't use /token endpoint. It's based on request to /auth with parameter "response_type" set to "token".

You are using friendsofsymfony/oauth2-php library which is supporting this flow and the only check that it's doing is checking if storage implements IOAuth2GrantImplicit. You added this interface to OAuthStorage and with this setup I guess it's always possible for every client with "authorization_code" grant type enabled to add "response_type=token" and use implicit flow.

Is there any way to disable it that I can't see or every client by default has implicit flow enabled? Because that doesn't look like secure default configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant