Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide documentation for Symfony4 #2861

Open
polishExperiment opened this issue Oct 10, 2018 · 8 comments
Open

Provide documentation for Symfony4 #2861

polishExperiment opened this issue Oct 10, 2018 · 8 comments

Comments

@polishExperiment
Copy link

This is feature request.

Symfony 4.x

Currently there is no documentation for Symfony 4.

This issue is an attempt at fixing that.

@polishExperiment
Copy link
Author

Could someone put me as an assignee?
Could someone put a label Documentation or give me access to do that myself?

@XWB
Copy link
Member

XWB commented Oct 15, 2018

Feel free to open a pull request :)

@alfonsodev
Copy link

I've configured successfully the bundle in Symfony 4
the changes needed are

  • On src/Entity/User.php change the namespace form
namespace AppBundle/User;

to

namespace App\Entity;
  • The configuration needs to be in its own file
    Create a new file called config/packages/fos_user_bundle.yml
fos_user:
    db_driver: orm # other valid values are 'mongodb' and 'couchdb'
    firewall_name: main
    user_class: App\Entity\User  # <--- Note the namespace must be App not AppBundle
    from_email:
        address: "%env(MAILER_ADDRESS)%"
        sender_name: "%env(MAILER_SENDER_NAME)%"
                user_checker: fos_user.user_checker

needs to be changed to

                user_checker: security.user_checker

seems to work after this change, but I'm not sure this is 100% correct
as @xabbuh points out in the below PR fos_user.user_checker is still defined in security.yml file of the bundle.
#2867
Also it would be needed to add a new element in the dropdown to point to version 4
image on the Symfony documentation site

@Clindbergh
Copy link

Also required:

You've to add the following to the config/packages/framework.yaml:

framework:
    # ... other stuff ...
    
    templating:
        engines: ['twig', 'php']

Originally posted by @devtronic in #2870 (comment)

@alfonsodev
Copy link

alfonsodev commented May 13, 2019

Right now the Official Symfony website is displaying this warning,
image

One suggestion @XWB, I think that we need to create a 4.x branch and then we can open a pull request with the updated documentation, master and 4.x can be the same, but I suspect that Symfony website convention is to read from version number branch to match their dropdown switcher for versions.
Also, it would be great to have a label for Symfony 4 to group all related issues, specially for newcomers.

Thanks you!

@shakaran
Copy link

@XWB any update with this? Could you create the branch 4.x as suggested by @alfonsodev ?

@tattali
Copy link

tattali commented Jul 31, 2019

Feel free to open a pull request :)

#2885

@TangMonk
Copy link

It is really necessary for Symfony 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants