Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI rule to force increasing of the Executor::VERSION on each release #1835

Closed
xgreenx opened this issue Apr 17, 2024 · 1 comment · Fixed by #1898
Closed

Add CI rule to force increasing of the Executor::VERSION on each release #1835

xgreenx opened this issue Apr 17, 2024 · 1 comment · Fixed by #1898
Assignees
@xgreenx

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Apr 17, 2024

No description provided.

@xgreenx xgreenx mentioned this issue Apr 17, 2024
Merged
2 tasks
@MitchTurner
Copy link
Member

We are worried that two versions of the bytecode might have the same Executor::VERSION. This could cause a fork in the blockchain.

If we can guarantee somehow that each release has a new Executor::VERSION, then this isn't really a problem

@xgreenx xgreenx self-assigned this May 7, 2024
@xgreenx xgreenx mentioned this issue May 17, 2024
Merged
1 task
xgreenx added a commit that referenced this issue May 27, 2024
@xgreenx @MitchTurner
Enforce increasing of the Executor::VERSION on each release (#1898)
3fddb12 
Closes #1835


### Before requesting review
- [x] I have reviewed the code myself

---------

Co-authored-by: Mitchell Turner <james.mitchell.turner@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xgreenx xgreenx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enforce increasing of the Executor::VERSION on each release FuelLabs/fuel-core
2 participants
@MitchTurner @xgreenx