-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tx dependency estimation #1380
Labels
enhancement
New feature or request
Comments
6 tasks
segfault-magnet
added a commit
that referenced
this issue
Jun 6, 2024
closes: #1380 The number of variable outputs is now determined by filling the dry-run tx with as much variable outputs as the node will allow and counting the number of `TransferOut` receipts made by the dry run. --------- Co-authored-by: Ahmed Sagdati <ahmed.sagdati@fuel.sh> Co-authored-by: Oleksii Filonenko <12615679+Br1ght0ne@users.noreply.github.com> Co-authored-by: hal3e <git@hal3e.io>
hal3e
added a commit
that referenced
this issue
Jun 11, 2024
closes: #1380 The number of variable outputs is now determined by filling the dry-run tx with as much variable outputs as the node will allow and counting the number of `TransferOut` receipts made by the dry run. --------- Co-authored-by: Ahmed Sagdati <ahmed.sagdati@fuel.sh> Co-authored-by: Oleksii Filonenko <12615679+Br1ght0ne@users.noreply.github.com> Co-authored-by: hal3e <git@hal3e.io>
6 tasks
hal3e
added a commit
that referenced
this issue
Jun 12, 2024
closes: #1380 The number of variable outputs is now determined by filling the dry-run tx with as much variable outputs as the node will allow and counting the number of `TransferOut` receipts made by the dry run. --------- Co-authored-by: Ahmed Sagdati <ahmed.sagdati@fuel.sh> Co-authored-by: Oleksii Filonenko <12615679+Br1ght0ne@users.noreply.github.com> Co-authored-by: hal3e <git@hal3e.io>
hal3e
added a commit
that referenced
this issue
Jun 12, 2024
closes: #1380 The number of variable outputs is now determined by filling the dry-run tx with as much variable outputs as the node will allow and counting the number of `TransferOut` receipts made by the dry run. --------- Co-authored-by: Ahmed Sagdati <ahmed.sagdati@fuel.sh> Co-authored-by: Oleksii Filonenko <12615679+Br1ght0ne@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently,
estimate_tx_dependencies
initiates a simulation for every dependency it needs to resolve.@segfault-magnet suggested:
To reduce the number of simulations performed, we can add a high number of variable outputs to the tx before simulation and then inspect it afterwards to see how many were used.
Additionally, we'll have to watch the tx size limit. We can only add so many variable outputs until the limit is reached, then if the tx still reverts with missing outputs we have to communicate that there is no way of constructing a valid transaction.
The text was updated successfully, but these errors were encountered: